Skip to content

BK-2408 Convert images which do not support CMYK to JPEG for print PDF output #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ride90 merged 1 commit into from
Mar 22, 2018
Merged

BK-2408 Convert images which do not support CMYK to JPEG for print PDF output #854

ride90 merged 1 commit into from
Mar 22, 2018

Conversation

@ride90
Copy link
Member

@ride90 ride90 commented Mar 21, 2018

No description provided.

@ride90 ride90 requested a review from eos87 March 21, 2018 15:59
@ride90
Copy link
Member Author

ride90 commented Mar 21, 2018

Hi @eos87 ,

Check this pr.
To test it set COLOR_SPACE_CONVERTER = True and configure CMYK2RGB_CONVERTER_CMYK_PROFILE_PATH and CMYK2RGB_CONVERTER_RGB_PROFILE_PATH, upload a PNG image in the editor, insert it in the chapter and export a book as PDF pro print. In the asset's folder instead of PNG (RGBA) image must be JPEG (RGB).

@ride90
Copy link
Member Author

ride90 commented Mar 22, 2018

Hi @eos87 ,
I'm going to merge it since it is a blocker for now.

@ride90 ride90 merged commit 0984ef8 into master Mar 22, 2018
@ride90 ride90 deleted the BK-2408 branch March 26, 2018 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eos87 eos87 Awaiting requested review from eos87

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ride90