Skip to content

Conversation

@ride90
Copy link
Member

@ride90 ride90 commented Nov 7, 2017

Hi @eos87 ,
Finally this fat PR is here.
It still has some issues, I guess user will not experience them in 99 percents of cases :)
I hide images from "contentrevision" for now, because we are not displaying images in diff correctly.
Image layouts feature for now supported only by epub 2/3 and xhtml outputs.
It also supports pdfreactor output, you can find update for css in pdfreactor repo (only one theme), other themes will be updated by @MiczFlor with generator.

@eos87
Copy link
Contributor

eos87 commented Nov 22, 2017

Hi @ride90, it looks pretty good, although I found small issue.

image

To reproduce:

  1. Add an image
  2. Edit Layouts (play with different options and close modal saying you need more than one image)
  3. Click Remove
  4. You will see the error

I saw another which was a modal warning saying about full page image, but I was unable to reproduce it, after seeing that modal I was not able to do any other change. I'll keep trying and If I find something I'll let you know.

Other than that, it looks really good! great work my friend :)

@ride90
Copy link
Member Author

ride90 commented Nov 22, 2017

HI @eos87 , yes, I was able to reproduce this issue.
It is not connected with image layout feature (it feels like it is actually). I will provide fix in separate pr.
Thank you for a review.

@ride90 ride90 merged commit a47b84f into booktype:master Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants