-
Notifications
You must be signed in to change notification settings - Fork 9
Plugin implementation #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dylan-bitovi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been playing around with this and hashing it out with Connor over Slack. Everything looks good to me :)
mickmcgrath13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this hooked up prior to merging:
https://docs.docker.com/engine/reference/builder/#onbuild
…uirements The plugins-base ONBUILD stage should require `bitops.config.yaml` file only per plugins documentation so users can build their own BitOps image
It's replaced by the publish-docs.yaml for the `main` branch
* Fix 'disbatch' -> 'dispatch' typo in the CD workflows * Additional image tagging for ':latest', ':dev', and ':base' * Additional image tagging for ':latest', ':dev', and ':base' * Adjust the base workflow with additional release tag * Remove the 'v' prefix from the v1.2.3 for docker tagging * Match image tag that ends with 'omnibus'
* Fix plugins install not returning correct exit code on failure Fixes #239 * Use the proper logger.error on a plugin failure
Plugin implementation using Python (#54)
Overview
If
plugin.config.yml(new file) is as followsThen on
docker build,scripts/setup/install_plugins.pyis called togit clonethefav-colorrepo toscripts/plugins/fav-color/scripts/plugins/fav-color/install.shif it existsDuring BitOps execution,
$SCRIPTS_DIR/plugins/deploy.pyis called to loop through all plugins and:PLUGIN_DIRandENVIRONMENT_DIR$PLUGIN_DIR/bitops.schema.yamland$ENVIRONMENT_DIR/bitops.config.yamlCLI_OPTIONSscripts/plugins/fav-color/deploy.shTesting
Docker Build
We can see in the
docker build -t temp .log, thatRuntime
Operations Repo
My operations repo contains only 1 file
test/fav-color/bitops.config.yaml:BitOps execution (truncated):
We can see that