Fix 'base' image docker tagging #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccapell
reviewed
Aug 9, 2022
ccapell
reviewed
Aug 9, 2022
Contributor
|
👍 Thanks for bumping the base image @armab |
Contributor
Author
|
Also added some colors to the docker deploy script for better 👀
|
PhillypHenning
added a commit
that referenced
this pull request
Aug 11, 2022
* Initial Documentation update DevOps2-90 (#264) * Initial Documentation update DevOps2-90 * Created Getting Started page, various updates * Minor updates * Fix 'base' image docker tagging (#265) * Fix 'base' image docker tagging * Add message coloring for the docker publish script * Add more documentation for the docker publish script Co-authored-by: Chris Capell <57496718+ccapell@users.noreply.github.com> Co-authored-by: Eugen C <1533818+armab@users.noreply.github.com>
arm4b
added a commit
that referenced
this pull request
Aug 11, 2022
- On every push to `main` branch build current `omnibus` image and publish it as `bitops:dev` Docker tag - It should be done `FROM bitovi/bitops:dev-base` Docker image already built and deployed for the `main` branch (#265)
PhillypHenning
added a commit
that referenced
this pull request
Aug 11, 2022
* Fixing a fooling mistake * ff (#276) * Initial Documentation update DevOps2-90 (#264) * Initial Documentation update DevOps2-90 * Created Getting Started page, various updates * Minor updates * Fix 'base' image docker tagging (#265) * Fix 'base' image docker tagging * Add message coloring for the docker publish script * Add more documentation for the docker publish script Co-authored-by: Chris Capell <57496718+ccapell@users.noreply.github.com> Co-authored-by: Eugen C <1533818+armab@users.noreply.github.com> * Adding to the ops_repo doc Co-authored-by: Chris Capell <57496718+ccapell@users.noreply.github.com> Co-authored-by: Eugen C <1533818+armab@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix naming in the workflows so on merge to the default
mainbranch we push currentdev-baseDocker tag.Looks like we relied on some old values like
plugins-base-RCSome visualisation improvements to colorise the docker deploy script messages with green in CI, otherwise it's hard to figure out the exact tags built and pushed
