Skip to content

Conversation

@mickmcgrath13
Copy link
Contributor

Description

Removes plugin and deployments from bitops.config.yaml for base

Fixes #252

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Local docker build to ensure it still works.

It turns out that ONBUILD RUN doesn't take effect for the image created from the Dockerfile in which ONBUILD is defined, and the only place in the base Dockerfile where the plugin config is referenced is in the install file (called from ONBUILD)

In other words, even though the plugins were defined in the base bitops config, they weren't actually being installed.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@mickmcgrath13 mickmcgrath13 merged commit ee552ca into main Aug 4, 2022
@mickmcgrath13 mickmcgrath13 deleted the 252-remove-plugins-from-base-config branch August 4, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove plugins and deployment blocks from bitops.config.yaml

2 participants