-
Notifications
You must be signed in to change notification settings - Fork 5.9k
BIP376: Spending Silent Payment outputs with PSBTs #2089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
BIP376: Spending Silent Payment outputs with PSBTs #2089
Conversation
murchandamus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start, most parts seem to already be here. Would be great to get some more eyes on this from other people working on Silent Payments.
…tion of 'Reference implementation'
|
I have pushed the changes in separated commits, to squash later. |
|
What’s the next step here? Will you be asking for people to provide some review, do you still have planned work, are there any open questions? |
|
So far, I haven't received any negative feedback on the proposal, so I plan to do a second round of review on the rationale. I would like to steel-man the argument for this approach against the other alternatives. |
|
Assigned BIP376. Please update the BIP and Assigned headers in the preamble, add a table entry in the README for your proposal, and update your documents filename. |
43d3ce2 to
aa4c4ed
Compare
|
While weighing the requirement of BIP 375, I detected there is no mention of how to source the base key to which the PSBT_IN_SP_TWEAK is added. I have multiple ideas for this:
This would be a source of ambiguity. I will consider the options and update once I've a conclusion. |
|
Okay, I’ll consider this in your court until you state otherwise in a comment here. :) |
|
Good catch. I don't think this should be left unspecified. Further, I think this choice can be simplified by considering the requirements of hardware wallets. I checked the firmware for both the Coldcard and the BitBox02 - both derive private keys from derivation paths, not public keys. While you could use To avoid this I suggest creating a new field called |
After considering how to explain the difficulty of making BIP 341 and BIP 352 compatible to avoid the addition of this field, I decided to remove the paragraph completely, because at the end, the discussion if BIP 352 could have been made differently to be compatible with BIP 341 tag hashes and reuse BIP 371 fields, belongs to BIP 352 and not here. This BIP should consider BIP 352 as it is. Changes to BIP 352 belong to a different BIP proposal.
09e9b51 to
2a3ca6a
Compare
|
I have revised the spec to address grammar and phrasing, and included the following updates regarding content:
|
Abstract
This document proposes an additional per input field for BIP 370 PSBTv2 that allows BIP 352 silent payment tweaks to be included in a PSBT of version 2. This field will be relevant to silent payment outputs spending.
Mailing list discussion: https://groups.google.com/g/bitcoindev/c/Kap7NMwzl2k
Delving bitcoin discussion: https://delvingbitcoin.org/t/bip352-psbt-support/877/32