This repository was archived by the owner on Mar 13, 2024. It is now read-only.
Add actions to settings form template#66
Merged
ampersarnie merged 3 commits intodevelopfrom Jan 14, 2019
Merged
Conversation
ampersarnie
previously requested changes
Jan 14, 2019
Member
ampersarnie
left a comment
There was a problem hiding this comment.
Actions and filters should have a DocBlock as-per-WordPress documentation standards. We also have them elsewhere in the theme so I think we need to stay consistent. Nothing major, just a sentence would do imo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Will require Wiki updates if merged - please ping me.