standard ruby impl #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… implementation of the script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like the idea of your vim-bundle script, but had some issues with it on various platforms I was working on.
I thought I'd give writing it using standard ruby libraries a try rather than shelling out. If you like these changes, the final change I'd make would be to git mv vim-bundle.rb vim-bundle, but thought keeping them separate may make the changes more readable.
I realize that you are probably working on a system with a proper shell (M$ command prompt with cygwin/rails instailler) so no worries if you aren't interested in this pull request.
If not, I'd still appreciate any feedback on the changes as I'm still getting up to speed on Ruby and and sure I am missing many of the standard Ruby idioms.
Thanks,
-jacobd