Skip to content

Conversation

@alexmoore
Copy link
Contributor

@alexmoore alexmoore commented Jul 18, 2016

This supersedes PR #610 (CLIENTS-922), by adding tests to the original PR.

@alexmoore
Copy link
Contributor Author

Special thanks to @bwittwer for the original PR!

@lukebakken
Copy link
Contributor

@alexmoore please to be fixing your builds :-P

[WARNING] /home/buildbot/masters/riak/java-client-test/build/src/test/java/com/basho/riak/client/core/RiakClientTest.java:[53,90] unchecked cast
  required: com.basho.riak.client.core.RiakFuture<java.lang.String,java.lang.String>
  found:    com.basho.riak.client.core.RiakFuture

@lukebakken
Copy link
Contributor

What happens when you execute a long-running Riak command, but specify a short timeout? Does the client disregard the value when returned by Riak?

@alexmoore
Copy link
Contributor Author

Yep, the command's execution will throw a TimeoutException(), and unblock the user thread. The operation will continue to process on Riak && the client's backend/netty threads until it completes in some fashion.

@lukebakken
Copy link
Contributor

OK I just want to make sure that the data returned from Riak is discarded and not used somehow by a different command.

@lukebakken
Copy link
Contributor

Other than my concern, 👍

@alexmoore
Copy link
Contributor Author

Nope, it should be discarded once the operation is complete, and the resources returned to the pool. It'll keep running in the background, but we'd need to add operation cancellation in to fix that (another issue).

@alexmoore alexmoore merged commit c09cd1f into develop Jul 18, 2016
@alexmoore alexmoore deleted the 609-add-synchronous-execute-timeout branch July 18, 2016 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants