refactor(metering): move tests inline #346
Merged
+820
−859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
This was referenced Jan 11, 2026
danyalprout
pushed a commit
that referenced
this pull request
Jan 11, 2026
## 📝 Summary <!--- A general summary of your changes --> ## 💡 Motivation and Context <!--- (Optional) Why is this change required? What problem does it solve? Remove this section if not applicable. --> --- ## ✅ I have completed the following steps: * [ ] Run `make lint` * [ ] Run `make test` * [ ] Added tests (if applicable)
8695f6f to
fa14653
Compare
- Add MeteringTestContext for unit tests that don't need a full node - Move meter.rs tests inline using MeteringTestContext (sync tests) - Move block.rs tests inline using MeteringTestContext (sync tests) - Move rpc.rs tests inline using TestHarness with MeteringExtension - Delete tests/ directory (all tests now inline) - Update lib.rs to expose test_utils with #[cfg(any(test, feature = "test-utils"))]
fa14653 to
64ae567
Compare
danyalprout
reviewed
Jan 12, 2026
Address PR review feedback: - Delete test_utils.rs and remove test-utils feature to avoid duplication - Use TestHarness from base-client-node for all tests - Remove envelope_from_signed helper - use direct conversion - Remove unused imports
danyalprout
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tests/directory to inline#[cfg(test)]modules inblock.rs,meter.rs, andrpc.rstests/meter.rs,tests/meter_block.rs,tests/meter_rpc.rsTest plan
cargo test -p base-metering- all 18 tests passcargo +nightly clippy -p base-metering --tests- no warnings