Add MultisigScriptDeposit extension for L1→L2 deposits #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🟡 Heimdall Review Status
|
Contributor
Author
|
Since PR #170 makes some changes to the |
jackchuma
reviewed
Jan 5, 2026
|
|
||
| /// @notice Returns the OptimismPortal address on L1 | ||
| /// @dev This is the portal contract that will be called to initiate the L2 deposit | ||
| function _optimismPortal() internal view virtual returns (address); |
Contributor
There was a problem hiding this comment.
I think we can provide a virtual function implementation for this below that returns the associated address based on the chain ID. This only exists on Sepolia and Mainnet and to my knowledge the addresses have never changed. Would be nice to not require every task to override this
| /// | ||
| /// Future enhancement: This could be expanded to calculate gas automatically | ||
| /// from per-call gas estimates provided in an extended Call3Value struct. | ||
| function _l2GasLimit() internal view virtual returns (uint64); |
Contributor
There was a problem hiding this comment.
It would also be ideal to not have to supply a hardcoded value for this. Is there a way we can simulate the call on a fork below within _buildCalls so we can estimate the value during script execution?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
MultisigScriptDeposit, an extension ofMultisigScriptthat simplifies L1→L2 deposit transactions.More specifically:
_buildL2Calls()instead of manually wrapping indepositTransactionOptimismPortal.depositTransactiontargetingCBMulticallon L2