Fix: LocalizationProvider.GetString with fallback culture
#484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix method `LocalizationProvider.GetString(string, CultureInfo?)` to correctly handle fallback culture. * Introduce tests for fallback culture and key return behavior in `LocalizationProviderTest`. Implement a FakeResourceManager for resource simulation. * `LocalizationProvider` now has full code coverage Should resolve issue 483
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #484 +/- ##
=====================================
Coverage ? 97%
=====================================
Files ? 99
Lines ? 3400
Branches ? 0
=====================================
Hits ? 3295
Misses ? 105
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
karljj1
approved these changes
Jul 2, 2025
Member
Author
|
Thanks for the review |
This was referenced Sep 15, 2025
This was referenced Sep 23, 2025
This was referenced Oct 1, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalizationProvider.GetString(string, CultureInfo?)to correctly handle fallback culture.LocalizationProviderTest. Implement a FakeResourceManager for resource simulation.LocalizationProvidernow has full code coverageShould resolve issue 483