Skip to content

Refactor parsing for thread safety #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
axunonb merged 2 commits into from
Mar 3, 2025
Merged

Refactor parsing for thread safety #467

axunonb merged 2 commits into from
Mar 3, 2025

Conversation

@axunonb
Copy link
Member

@axunonb axunonb commented Feb 28, 2025 •
edited
Loading

  • Refactored parsing logic in Parser.cs with a new ParserState record, replacing stateful instance variables.
  • Make Parser.ParseFormat(...) thread-safe

Resolves #466

@axunonb
Refactor formatting and parsing for thread safety
97caacb 
- Refactored parsing logic in `Parser.cs` with a new `ParserState` record.
- Make `Parser.ParseFormat(...)` thread-safe

Resolves axuno#466
@axunonb axunonb requested a review from karljj1 February 28, 2025 23:55
@codecov
Copy link

codecov bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97%. Comparing base (423466b) to head (f3dbee5).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@         Coverage Diff         @@
##           main   #467   +/-   ##
===================================
  Coverage    97%    97%           
===================================
  Files        96     99    +3     
  Lines      3341   3383   +42     
===================================
+ Hits       3237   3279   +42     
  Misses      104    104

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@axunonb
Copy link
Member Author

axunonb commented Mar 3, 2025 •
edited
Loading

Thanks for your review.

@axunonb axunonb merged commit 0f1f1bf into axuno:main Mar 3, 2025
5 checks passed
@axunonb axunonb deleted the pr/parser-parseformat branch March 3, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karljj1 karljj1 karljj1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make Parser.ParseFormat thread-safe

2 participants

@axunonb @karljj1