feat: Ensure Format instances get returned to object pool #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Ensure, that the Format returned from internal string parsing gets returned to object pool * refactor: Add static method to create FormattingInfo using object pool * docs: Update xmldoc and comments in Parser and SmartFormatter * test: Add missing unit tests for SmartFormatter.Format overload
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
===================================
- Coverage 96% 96% -0%
===================================
Files 92 92
Lines 3226 3230 +4
===================================
+ Hits 3108 3111 +3
- Misses 118 119 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatreturned from internal string parsing gets returned to object poolFormattingInfousing object pool, and remove redundant privateSmartFormatter.Format(FormatDetails, Format, object?)ParserandSmartFormatterSmartFormatter.Formatoverload