Fixes millisecond parsing in custom DateTime parser #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorrowe
added a commit
that referenced
this pull request
Oct 3, 2014
Fixes millisecond parsing in custom DateTime parser
Contributor
|
Sorry for the slow response. We've been nose down on the 2.0 stable release of aws-sdk-core and the preview release of aws-sdk-resources. This should go out with the next release. |
trevorrowe
added a commit
that referenced
this pull request
Oct 8, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling the parser would result in the milliseconds being discarded by DateTime#civil:
Now they are correctly set:
As an added bonus, this also works around a bug in the JRuby implementation of DateTime#civil, where the last argument must be the timezone offset. Whereas MRI just ignores an incorrect offset argument.