Skip to content

Convert existing boolean checks to matcher syntax #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chiphogg merged 2 commits into from
May 7, 2025
Merged

Convert existing boolean checks to matcher syntax #413

chiphogg merged 2 commits into from
May 7, 2025

Conversation

@hoffbrinkle
Copy link
Member

@hoffbrinkle hoffbrinkle commented May 6, 2025 •
edited
Loading

This converts exiting the existing boolean assertion checkers

  • ASSERT_TRUE
  • ASSERT_FALSE
  • EXPECT_TRUE
  • EXPECT_FALSE

to the appropriate matcher.

This also puts any using declarations within the namespace scope.

Partial implementation for #404.

@hoffbrinkle hoffbrinkle marked this pull request as draft May 6, 2025 12:48
@hoffbrinkle hoffbrinkle force-pushed the hoffbrinkle/assert_boolean_cleanup branch 2 times, most recently from 6aaf289 to 8716aae Compare May 6, 2025 15:27
@hoffbrinkle hoffbrinkle force-pushed the hoffbrinkle/assert_boolean_cleanup branch from 8716aae to b6a0591 Compare May 6, 2025 15:29
@hoffbrinkle hoffbrinkle marked this pull request as ready for review May 6, 2025 15:38
@chiphogg chiphogg merged commit cc1eb19 into main May 7, 2025
15 checks passed
@chiphogg chiphogg deleted the hoffbrinkle/assert_boolean_cleanup branch May 7, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chiphogg chiphogg chiphogg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hoffbrinkle @chiphogg