Support powers and roots for unit wrappers #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unlocks some basic missing functionality for `Constant` and `SymbolFor`: namely, we should be able to pass instances of them to `squared()`, `sqrt()`, `pow<N>()`, `root<N>()`, and so on. Fixes #375.
geoffviola
approved these changes
Jan 15, 2025
Contributor
geoffviola
left a comment
There was a problem hiding this comment.
Motivation, implementation, and tests look good.
| StaticAssertTypeEq<decltype(root<8>(mol)), UnitWrapper<decltype(root<8>(Moles{}))>>(); | ||
| } | ||
|
|
||
| // UnitWrapper<Meters>{} * meters_pt; |
Contributor
There was a problem hiding this comment.
Q: Are these tests irrelevant now?
Member
Author
There was a problem hiding this comment.
Oops... actually, no! We deleted ForbidsComposingWith in #227, so I thought we forgot to remove this, but reading that PR summary I see that leaving these here was intentional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unlocks some basic missing functionality for
ConstantandSymbolFor: namely, we should be able to pass instances of them tosquared(),sqrt(),pow<N>(),root<N>(), and so on.Fixes #375.