Exact match #8
Merged
Exact match #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micheleriva
requested changes
Jul 12, 2022
|
Hi @mateonunez! |
micheleriva
approved these changes
Jul 12, 2022
|
Awesome, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the #1 using a parameter that determinates if the search actions requires an exact match or not.
The
findmethod of Trie nodes now accept an object as a single parameter. The type has been added:FindParams.The solution found is to insert a check in the recursive function
findAllWords, if the search actions requires an exact match and the word given by the last node doesn't match with the prefix, returns the initial output.I wrote the tests for this, I'm considering add more tests if necessary.