Fix and Improve trackball interactivity#227
Merged
9prady9 merged 1 commit intoarrayfire:masterfrom Apr 26, 2021
Merged
Conversation
- Fixed bug in trackball computation that was incorrectly using angle
in degrees instead of radians
- Add custom Cursors for zoom and rotation modes to visually aid the
user
- Hand cursor appears when rotation is activated(Mouse Right button
drag)
- Arrow with top and bottom heads is activated when zoom in/out mode
is active(Ctrl + Left Right button) to hint the required cursor
movement for desired zoom in or zoom out
SDL window toolkit additionally has custom move cursor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in degrees instead of radians
user
drag)
is active(Ctrl + Left Right button) to hint the required cursor
movement for desired zoom in or zoom out
SDL window toolkit additionally has custom move cursor.
Change(s)
Trackball rotation has a bug in computing the angle.
Current Behavior
Incorrectly uses degrees unit instead of radians
New Behavior
Fixed angle units and improved interactivity hints
Breaking Change(s)
None