Use glad, glm system packages automatically if available#226
Merged
9prady9 merged 2 commits intoarrayfire:masterfrom Apr 22, 2021
Merged
Use glad, glm system packages automatically if available#2269prady9 merged 2 commits intoarrayfire:masterfrom
9prady9 merged 2 commits intoarrayfire:masterfrom
Conversation
added 2 commits
April 22, 2021 20:02
In the case they aren't, then FetchContent from CMake is used to retrieve the source code for glm and glad during CMake configure time. Tested the cmake logic in the following scenarios: - glad and glm are available via package manager like vcpkg - One of the two, glad and glm, is only available via package manager - None of the two, glad and glm are not installed on the system This change also added glm, glad to vcpkg manifest file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2. Increased min required C++ standard to C++17, examples are still C++11 though3. Use correct LINK keyword for static freeimage linking