Skip to content

Allow upload using binaries from build-path #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Allow upload using binaries from build-path #675

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d46c94e
Upgrade go-properites-map to 1.1.0
cmaglie Apr 23, 2020
ac21bf6
Renamed variable uploadToolPattern → uploadToolName
cmaglie Apr 23, 2020
2c9900b
removed useless variables
cmaglie Apr 23, 2020
95814a4
moved uploadProperties.ExpandPropsInString after proper check
cmaglie Apr 23, 2020
4646964
fixed typo
cmaglie Apr 24, 2020
0a05d7f
Explicitly set build-path in compile command
cmaglie Apr 24, 2020
34a468a
upload now can use build path to retrieve build artifacts
cmaglie Apr 24, 2020
75e0f37
Added trace logs in upload command
cmaglie Apr 24, 2020
53a25fa
Added --build-path and --upload-from-build-path flags in upload command
cmaglie Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed useless variables
  • Loading branch information
@cmaglie
cmaglie committed Apr 23, 2020
commit 2c9900bfe079ae6b1a7fa3f19be75832db4cf8e9
6 changes: 2 additions & 4 deletions commands/upload/upload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,7 @@ func Upload(ctx context.Context, req *rpc.UploadReq, outStream io.Writer, errStr
}

// Set properties for verbose upload
Verbose := req.GetVerbose()
if Verbose {
if req.GetVerbose() {
if v, ok := uploadProperties.GetOk("upload.params.verbose"); ok {
uploadProperties.Set("upload.verbose", v)
}
Expand All @@ -142,8 +141,7 @@ func Upload(ctx context.Context, req *rpc.UploadReq, outStream io.Writer, errStr
}

// Set properties for verify
Verify := req.GetVerify()
if Verify {
if req.GetVerify() {
uploadProperties.Set("upload.verify", uploadProperties.Get("upload.params.verify"))
} else {
uploadProperties.Set("upload.verify", uploadProperties.Get("upload.params.noverify"))
Expand Down