Skip to content

Remove not needed instance field in LoadSketch and NewSketch gRPC API #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion internal/cli/sketch/new.go
Original file line number Diff line number Diff line change
@@ -73,7 +73,6 @@ func runNewCommand(args []string, overwrite bool) {
}

_, err = sk.NewSketch(context.Background(), &rpc.NewSketchRequest{
Instance: nil,
SketchName: sketchName,
SketchDir: sketchDir,
Overwrite: overwrite,
844 changes: 408 additions & 436 deletions rpc/cc/arduino/cli/commands/v1/commands.pb.go

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions rpc/cc/arduino/cli/commands/v1/commands.proto
Original file line number Diff line number Diff line change
@@ -263,8 +263,6 @@ message VersionResponse {
}

message NewSketchRequest {
// Arduino Core Service instance from the Init response.
Instance instance = 1;
// New sketch name
string sketch_name = 2;
// Optional: create a Sketch in this directory
@@ -274,6 +272,8 @@ message NewSketchRequest {
string sketch_dir = 3;
// Specificies if an existing .ino sketch should be overwritten
bool overwrite = 4;

reserved 1;
}

message NewSketchResponse {
@@ -282,10 +282,10 @@ message NewSketchResponse {
}

message LoadSketchRequest {
// Arduino Core Service instance from the Init response.
Instance instance = 1;
// Absolute path to single sketch file or a sketch folder
string sketch_path = 2;

reserved 1;
}

message LoadSketchResponse {