Skip to content

Moving a sketch to another folder should move all files #6404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Moving a sketch to another folder should move all files #6404

wants to merge 1 commit into from

Conversation

facchinm
Copy link
Member

Fixes #6402

@ArduinoBot
Copy link
Contributor

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6404-BUILD-697-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6404-BUILD-697-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6404-BUILD-697-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6404-BUILD-697-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6404-BUILD-697-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

@facchinm facchinm mentioned this pull request Jun 23, 2017
Closed
@per1234
Copy link
Collaborator

per1234 commented Jun 24, 2017 •
edited
Loading

I just wanted to comment that, even if this PR doesn't fix #6402, it is a useful improvement. The previous behavior of only moving the primary sketch file regularly caused problems for people who downloaded a multi-file sketch from GitHub when that sketch is in the root of the repository. GitHub appends the branch name to the sketch folder, which forces the move, and breaks the sketch.

Example of the previous behavior causing problems: Espressobar/arduino-grind-timer#2

@facchinm facchinm added this to the Release 1.8.4 milestone Jul 25, 2017
@facchinm facchinm modified the milestones: Release 1.8.4, Next Aug 18, 2017
@ArduinoBot
Copy link
Contributor

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6404-BUILD-718-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6404-BUILD-718-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6404-BUILD-718-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6404-BUILD-718-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6404-BUILD-718-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

@per1234 per1234 mentioned this pull request Jul 30, 2018
Closed
facchinm added a commit to facchinm/Arduino that referenced this pull request Aug 20, 2018
@facchinm
Avoid performing non trivial operations on files
2839ffb 
Fixes arduino#6404 as per @cmaglie comment.
@facchinm facchinm mentioned this pull request Aug 20, 2018
Closed
@cmaglie
Copy link
Member

cmaglie commented Aug 23, 2018

We are searching a better solution for this problem, for now the commit has been reverted.
Follow ups on #7909

@cmaglie cmaglie closed this Aug 23, 2018
@cmaglie cmaglie deleted the movesketch_partial branch August 23, 2018 08:41
@per1234 per1234 mentioned this pull request May 3, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.
4 participants
@facchinm @ArduinoBot @per1234 @cmaglie