Various updates #88
Merged
Various updates #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon MacDonald <[email protected]>
Signed-off-by: Simon MacDonald <[email protected]>
Chore: tidy up coverage ignore comments
Ensure `fifo`, batchSize`, `batchWindow` are top-level `@queues` semantics properties
filmaj
approved these changes
Jan 8, 2026
Member
filmaj
left a comment
There was a problem hiding this comment.
LGTM, left a couple of minor non-blocking nits
macdonst
approved these changes
Jan 8, 2026
Contributor
macdonst
left a comment
There was a problem hiding this comment.
LGTM, let me know when it is merged and I will re-test my PR.
Member
|
just tried the RC and seems like batchSize and batchWindow not being passed to the config (but fifo does) 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping out! ✨
We really appreciate your commitment to improving Architect
To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:
mainnpm itfrom the repo root)readme.md, help docs, inline docs & comments, etc.)changelog.mdPlease also be sure to completed the CLA (if you haven't already).
Learn more about contributing to Architect here.
Thanks again!