chore(fcm): notification handling logic for sound field #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `IsGRPC` field from `PushNotification` struct - Simplify condition by removing `IsGRPC` check in `GetAndroidNotification` - Add checks for `APNS` and `Android` fields in `GetAndroidNotification` - Remove `IsGRPC` initialization in `Send` method of `Server` Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
- Change `req.Sound` type check from string to interface - Add type assertion for `req.Sound` to string - Ensure `req.APNS` and `req.Android` are only set if `req.Sound` is a string Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsGRPCfield fromPushNotificationstructIsGRPCcheck inGetAndroidNotificationAPNSandAndroidfields inGetAndroidNotificationIsGRPCinitialization inSendmethod ofServerfix #795