Fix TestCLICreateCommand failing test#897
Merged
jglogan merged 1 commit intoapple:mainfrom Nov 18, 2025
Merged
Conversation
testPublishPortParserMaxPorts and testPublishPortParserTooManyPorts run returns 4 parameters. Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
3936c66 to
6a864bf
Compare
Contributor
|
@tico88612 That was quick! I think my build of #896 might finish quicker and it includes that fix as well. But if it takes long to get a review done for that one we can just merge yours once the build completes. Thanks! |
Contributor
Author
|
Yeah, I just noticed you fixed it in #896. Don't worry, if your PR gets merged faster, I don't mind if you close this PR. 😁 |
saehejkang
pushed a commit
to saehejkang/container
that referenced
this pull request
Jan 27, 2026
Signed-off-by: ChengHao Yang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
testPublishPortParserMaxPortsandtestPublishPortParserTooManyPortsrun returns 4 parameters.Related #872
Testing