Skip to content

CLI: stop and kill should error on not found containers#878

Open
dcantah wants to merge 1 commit intoapple:mainfrom
dcantah:change-stop-and-kill-behavior
Open

CLI: stop and kill should error on not found containers#878
dcantah wants to merge 1 commit intoapple:mainfrom
dcantah:change-stop-and-kill-behavior

Conversation

@dcantah
Copy link
Member

@dcantah dcantah commented Nov 14, 2025

Today these go through and simply print nothing if you provide
container IDs that don't exist, which is a tad odd. This change
makes it so we actually send rpcs to the daemon and have it yell
at us.

➜  container git:(rm-stop-error) ✗ ./bin/container stop foo bar baz
Warning! Running debug build. Performance may be degraded.
Error: internalError: "failed to stop container" (cause: "notFound: "container with ID baz not found"")
internalError: "failed to stop container" (cause: "notFound: "container with ID foo not found"")
internalError: "failed to stop container" (cause: "notFound: "container with ID bar not found"")
➜  container git:(rm-stop-error) ✗ ./bin/container rm foo bar baz
Warning! Running debug build. Performance may be degraded.
Error: internalError: "failed to delete container" (cause: "notFound: "container with ID foo not found"")
internalError: "failed to delete container" (cause: "notFound: "container with ID baz not found"")
internalError: "failed to delete container" (cause: "notFound: "container with ID bar not found"")

@dcantah dcantah force-pushed the change-stop-and-kill-behavior branch from cd90009 to ace9702 Compare November 14, 2025 01:26
@dcantah dcantah marked this pull request as ready for review November 14, 2025 04:43
Today these go through and simply print nothing if you provide
container IDs that don't exist, which is a tad odd. This change
makes it so we actually send rpcs to the daemon and have it yell
at us.
@dcantah dcantah force-pushed the change-stop-and-kill-behavior branch from ace9702 to 3a6aefe Compare February 16, 2026 12:25
@dcantah dcantah requested a review from jglogan February 16, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments