CLI: stop and kill should error on not found containers#878
Open
dcantah wants to merge 1 commit intoapple:mainfrom
Open
CLI: stop and kill should error on not found containers#878dcantah wants to merge 1 commit intoapple:mainfrom
dcantah wants to merge 1 commit intoapple:mainfrom
Conversation
cd90009 to
ace9702
Compare
jglogan
requested changes
Nov 14, 2025
This was referenced Dec 18, 2025
Today these go through and simply print nothing if you provide container IDs that don't exist, which is a tad odd. This change makes it so we actually send rpcs to the daemon and have it yell at us.
ace9702 to
3a6aefe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today these go through and simply print nothing if you provide
container IDs that don't exist, which is a tad odd. This change
makes it so we actually send rpcs to the daemon and have it yell
at us.