Fix Info.plist system properties for symlinked container.#859
Merged
jglogan merged 2 commits intoapple:mainfrom Nov 7, 2025
Merged
Fix Info.plist system properties for symlinked container.#859jglogan merged 2 commits intoapple:mainfrom
container.#859jglogan merged 2 commits intoapple:mainfrom
Conversation
Member
|
|
- Regular `Bundle.main.infoDictionary` doesn't work in this case. - Load bundle using location presuming binary is under `Contents/MacOS`.
d7c45a9 to
8100be9
Compare
dcantah
approved these changes
Nov 6, 2025
adityaramani
approved these changes
Nov 7, 2025
jglogan
added a commit
to jglogan/container
that referenced
this pull request
Nov 10, 2025
- apple#859 added the traversal necessary to load the app bundle but forgot to resolve symlinks. This fix adds the resolution, making it possible to get default system properties from an app bundle Info.plist even if the user invokes a command from, for example, `/usr/local/bin/container` which is a symlink to the actual install path of the bundle.
7 tasks
jglogan
added a commit
that referenced
this pull request
Nov 10, 2025
- #859 added the traversal necessary to load the app bundle but forgot to resolve symlinks. This fix adds the resolution, making it possible to get default system properties from an app bundle Info.plist even if the user invokes a command from, for example, `/usr/local/bin/container` which is a symlink to the actual install path of the bundle. - Also fixes bugs where an incorrect executable path was supplied in some calls. - Breaking change: `CommandLine.executablePathUrl` extension moved from ContainerPlugin to ContainerVersion.
saehejkang
pushed a commit
to saehejkang/container
that referenced
this pull request
Jan 27, 2026
saehejkang
pushed a commit
to saehejkang/container
that referenced
this pull request
Jan 27, 2026
- apple#859 added the traversal necessary to load the app bundle but forgot to resolve symlinks. This fix adds the resolution, making it possible to get default system properties from an app bundle Info.plist even if the user invokes a command from, for example, `/usr/local/bin/container` which is a symlink to the actual install path of the bundle. - Also fixes bugs where an incorrect executable path was supplied in some calls. - Breaking change: `CommandLine.executablePathUrl` extension moved from ContainerPlugin to ContainerVersion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle.main.infoDictionarydoesn't work in this case.Contents/MacOS.Type of Change
Testing