Build: Fallback to Containerfile if Dockerfile not found#812
Merged
jglogan merged 1 commit intoapple:mainfrom Oct 27, 2025
Merged
Build: Fallback to Containerfile if Dockerfile not found#812jglogan merged 1 commit intoapple:mainfrom
jglogan merged 1 commit intoapple:mainfrom
Conversation
7 tasks
If a Dockerfile can't be found in the context dir, check for Containerfile. This does not implement .containerignore also, solely Containerfile for now. This also funnily enough fixes us not checking for the Dockerfile IN the context directory.. woops.
308b562 to
3060c38
Compare
jglogan
approved these changes
Oct 27, 2025
Closed
saehejkang
pushed a commit
to saehejkang/container
that referenced
this pull request
Oct 28, 2025
Closes apple#782 apple#99 If a Dockerfile can't be found in the context dir, check for the common alternative Containerfile. This does not implement .containerignore also, solely Containerfile for now. This also funnily enough fixes us not checking for the Dockerfile IN the context directory.. woops. ## Type of Change - [x] Bug fix - [x] New feature - [ ] Breaking change - [ ] Documentation update ## Testing - [x] Tested locally - [x] Added/updated tests - [x] Added/updated docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #782 #99
If a Dockerfile can't be found in the context dir, check for the common alternative Containerfile. This does not implement .containerignore also, solely Containerfile for now. This also funnily enough fixes us not checking for the Dockerfile IN the context directory.. woops.
Type of Change
Testing