Conversation
|
Not sure if I added the Maybe something to do with the encoding and decoding done in the |
|
Not sure the protocol with pinging maintainers, as I don't want to bloat anyone's notifications. But @jglogan , I would love to get some 👀 on this. Mainly to check if I am even taking the right steps in what we want accomplish here. |
|
@saehejkang I'll have a look next week. |
|
@saehejkang I'll have a review of this done by the end of the day. The main thing I want to consider is whether what you have here follows a pattern that we can apply to the metadata for all our managed resources. |
9fd5f2d to
638912c
Compare
Sources/Services/ContainerNetworkService/NetworkConfiguration.swift
Outdated
Show resolved
Hide resolved
jglogan
left a comment
There was a problem hiding this comment.
@saehejkang could you make the property name change and the deserialization change, and then we can merge this and use it as the pattern for the other PR.
Sources/Services/ContainerNetworkService/NetworkConfiguration.swift
Outdated
Show resolved
Hide resolved
Sources/Services/ContainerNetworkService/NetworkConfiguration.swift
Outdated
Show resolved
Hide resolved
efed155 to
19f4e75
Compare
- Closes apple#665 - Existing containers that don't have `creationDate` default to the epoch date.
Type of Change
Motivation and Context
Closes #665
Testing