Support following symlinks in tar when setting default kernel#575
Merged
katiewasnothere merged 1 commit intoapple:mainfrom Sep 4, 2025
Merged
Conversation
wlan0
reviewed
Sep 4, 2025
wlan0
requested changes
Sep 4, 2025
Contributor
wlan0
left a comment
There was a problem hiding this comment.
One correctness bug, LGTM otherwise
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
48329fd to
863a9ca
Compare
wlan0
approved these changes
Sep 4, 2025
3 tasks
katiewasnothere
added a commit
that referenced
this pull request
Sep 5, 2025
## Type of Change - [x] New feature ## Description Add option to force kernel setting and tests for CLI `kernel set`. Related to #575. ## Motivation and Context This PR adds additional tests to ensure that we can set kernels from local files, remote tar files, and local tar files. A new option `force` is added to the `kernel set` subcommand which will overwrite an existing kernel with the same name if one exists to make testing easier. The tests ensure that a container can be started with the newly set kernel and resets to the default recommended kernel when complete. ## Testing - [x] Tested locally - [x] Added/updated tests Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR checks if the found entry in the archive for the requested kernel path is a symlink, and if so, follows the symlink. I've opened a separate issue to track creating tests for kernel downloading here #574 and will create a follow-up PR for those.
Motivation and Context
This PR fixes an issue reported in #475 where installing a kernel from a tar archive does not follow symlinks in the archive.
Testing