Fix user arg passthrough for container create#393
Merged
katiewasnothere merged 1 commit intoapple:mainfrom Jul 29, 2025
Merged
Conversation
dcantah
approved these changes
Jul 29, 2025
Member
|
I approved a little hastily, can we make a simple test to create some container where the args uses something we would interpret as a flag and verify we don't fail (or whatever you think would be a good test). |
1d01712 to
a18f490
Compare
Contributor
Author
|
@dcantah added a simple test! |
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
a18f490 to
35040c3
Compare
dcantah
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches other container commands that rely on user arguments at the end, such as
container run. Closes #395.