Fix Race Condition in Container Removal (#130)#218
Merged
dcantah merged 1 commit intoapple:mainfrom Jun 17, 2025
Merged
Conversation
9862a5b to
d315cf2
Compare
- Add proper handling for container state transitions - Fix race condition test flakiness with improved error handling - Add missing .stopping case in BuilderStart.swift - Improve error messaging with container ID - Resolve build and test failures - Update license headers and formatting - Add helper methods for safer container management - Enhanced test logic to handle both immediate success and controlled failure cases Signed-off-by: ramsyana <[email protected]>
d315cf2 to
7c2ce8b
Compare
adityaramani
approved these changes
Jun 17, 2025
Contributor
adityaramani
left a comment
There was a problem hiding this comment.
Thanks for the fix!
dcantah
approved these changes
Jun 17, 2025
Member
|
Thanks for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a race condition when removing a container immediately after stopping it, caused by the
stopcommand returning before the container fully transitions to the stopped state (#130).Changes:
TestCLIRmRace.swiftwith robust test logic and helper methods (containerExists,safeRemove).CLITest.swiftwith missingdoRemovemethod.BuilderStart.swiftto handle.stoppingcase.Testing:
make test,make integration).make fmt).Hopefully, this will pass the integration tests on GitHub.