Wait for IO streams to complete before a process exits#198
Merged
adityaramani merged 3 commits intoapple:mainfrom Jun 16, 2025
Merged
Wait for IO streams to complete before a process exits#198adityaramani merged 3 commits intoapple:mainfrom
adityaramani merged 3 commits intoapple:mainfrom
Conversation
adityaramani
commented
Jun 13, 2025
Sources/CLI/RunCommand.swift
Outdated
Contributor
Author
There was a problem hiding this comment.
I think it makes sense to throw here since self is a struct and we cannot update self.ioTracker to be nil (without going throw a few hoops) - At least this way the client will know that something is off and they wont repeatedly call this wait method
ec7013f to
9f79e26
Compare
Signed-off-by: Aditya Ramani <a_ramani@apple.com>
Signed-off-by: Aditya Ramani <a_ramani@apple.com>
adityaramani
commented
Jun 14, 2025
dcantah
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a way for the CLI to wait until the IO streams from the SandboxService have been drained before closing them.
Follows the same pattern as apple/containerization#110
This change also performs some cleanup in the
SandboxService.startProcessmethod - splitting the code paths to handle the init process and an exec'd process into two different private methods to make easier reading