Change behavior of the default arguments in the plugin config#1063
Merged
katiewasnothere merged 1 commit intoapple:mainfrom Jan 20, 2026
Merged
Change behavior of the default arguments in the plugin config#1063katiewasnothere merged 1 commit intoapple:mainfrom
katiewasnothere merged 1 commit intoapple:mainfrom
Conversation
ba8a84f to
7733eef
Compare
7733eef to
eecf89e
Compare
jglogan
approved these changes
Jan 17, 2026
saehejkang
pushed a commit
to saehejkang/container
that referenced
this pull request
Jan 23, 2026
…1063) ## Type of Change - [x] New feature - [x] Breaking change ## Motivation and Context This PR changes the behavior of the `defaultArguments` field in the service plugin config. Previously, `defaultArguments` was functioning as a way to indicate how to start a plugin in the event that the plugin is loaded at boot (such as for the `container-core-images plugin`). However, we now follow a convention where all plugins have a "start" command that is used when launching the plugin, so this `defaultArguments` field wasn't really providing much. Instead, there are use cases where we may want to set default values to pass to a plugin. This PR repurposes the `defaultArguments` field for those use cases. As an example use case, there are scenarios where someone may want to use the AllocationOnlyVmnetNetwork even when running on macOS 26+. This PR adds the ability to pass in a command line option to the vmnet network plugin to specify that request. Combined with the `defaultArguments` plugin config change, a user may choose to set that field to ["--variant", "allocationOnly"] in the `container-network-vmnet-config.json` to use AllocationOnlyVmnetNetwork by default for all networks. ## Testing - [x] Tested locally
saehejkang
pushed a commit
to saehejkang/container
that referenced
this pull request
Jan 27, 2026
…1063) ## Type of Change - [x] New feature - [x] Breaking change ## Motivation and Context This PR changes the behavior of the `defaultArguments` field in the service plugin config. Previously, `defaultArguments` was functioning as a way to indicate how to start a plugin in the event that the plugin is loaded at boot (such as for the `container-core-images plugin`). However, we now follow a convention where all plugins have a "start" command that is used when launching the plugin, so this `defaultArguments` field wasn't really providing much. Instead, there are use cases where we may want to set default values to pass to a plugin. This PR repurposes the `defaultArguments` field for those use cases. As an example use case, there are scenarios where someone may want to use the AllocationOnlyVmnetNetwork even when running on macOS 26+. This PR adds the ability to pass in a command line option to the vmnet network plugin to specify that request. Combined with the `defaultArguments` plugin config change, a user may choose to set that field to ["--variant", "allocationOnly"] in the `container-network-vmnet-config.json` to use AllocationOnlyVmnetNetwork by default for all networks. ## Testing - [x] Tested locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
This PR changes the behavior of the
defaultArgumentsfield in the service plugin config. Previously,defaultArgumentswas functioning as a way to indicate how to start a plugin in the event that the plugin is loaded at boot (such as for thecontainer-core-images plugin). However, we now follow a convention where all plugins have a "start" command that is used when launching the plugin, so thisdefaultArgumentsfield wasn't really providing much. Instead, there are use cases where we may want to set default values to pass to a plugin. This PR repurposes thedefaultArgumentsfield for those use cases.As an example use case, there are scenarios where someone may want to use the AllocationOnlyVmnetNetwork even when running on macOS 26+. This PR adds the ability to pass in a command line option to the vmnet network plugin to specify that request. Combined with the
defaultArgumentsplugin config change, a user may choose to set that field to ["--variant", "allocationOnly"] in thecontainer-network-vmnet-config.jsonto use AllocationOnlyVmnetNetwork by default for all networks.Testing