[GH-2231] Implement is_ring #2232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Using this as an example PR for how to add a new geopandas function for this EPIC issue: #2230. All of the previous ones are a bit outdated after the refactors. |
24 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the is_ring property for GeoSeries, which tests if LineString geometries are closed rings (where the start and end points are identical).
- Implements the
is_ringproperty in both the base class and GeoSeries implementation - Adds comprehensive tests to verify functionality against GeoPandas behavior
- Provides detailed documentation with examples
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python/sedona/spark/geopandas/geoseries.py | Replaces NotImplementedError with actual ST_IsRing implementation |
| python/sedona/spark/geopandas/base.py | Adds complete property definition with documentation and examples |
| python/tests/geopandas/test_geoseries.py | Adds unit tests for the is_ring property with various geometry types |
| python/tests/geopandas/test_match_geopandas_series.py | Adds compatibility test to ensure behavior matches GeoPandas |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jiayuasu
approved these changes
Aug 6, 2025
Kontinuation
pushed a commit
to Kontinuation/sedona
that referenced
this pull request
Jan 21, 2026
* Implement is_ring * Also add test for geodataframe * Update python/tests/geopandas/test_match_geopandas_series.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Jia Yu <jiayu@wherobots.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes Geopandas: Implementis_ring#2231What changes were proposed in this PR?
Implement is_ring
How was this patch tested?
Added tests
Did this PR include necessary documentation updates?