Skip to content

Conversation

@Jackie-Jiang
Copy link
Contributor

Fix the way to identify the INT96 field

The old way breaks because of this bug fix: apache/parquet-java#3311
The name of the field is no longer "INT96"

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the Parquet library from version 1.16.0 to 1.17.0 and addresses a breaking change in how INT96 fields are identified. The upgrade was necessary due to a bug fix in parquet-java (PR #3311) that changed the field name representation for INT96 types.

Changes:

  • Bumped parquet version from 1.16.0 to 1.17.0 in the root POM
  • Updated INT96 field identification logic to check fixed-size byte arrays with documentation instead of relying on field names
  • Improved code consistency by removing unnecessary fully qualified class names and adding defensive assertions

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
pom.xml Updates parquet dependency version to 1.17.0
ParquetAvroRecordExtractor.java Refactors INT96 detection logic to use fixed-size and documentation checks instead of field name comparison, removes unused import, and simplifies Schema type references

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.26%. Comparing base (c244cd3) to head (d117095).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nputformat/parquet/ParquetAvroRecordExtractor.java 62.50% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #17504   +/-   ##
=========================================
  Coverage     63.25%   63.26%           
+ Complexity     1477     1476    -1     
=========================================
  Files          3167     3167           
  Lines        189175   189177    +2     
  Branches      28948    28950    +2     
=========================================
+ Hits         119661   119678   +17     
+ Misses        60235    60202   -33     
- Partials       9279     9297   +18     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.21% <62.50%> (+<0.01%) ⬆️
java-21 63.22% <62.50%> (-0.01%) ⬇️
temurin 63.26% <62.50%> (+<0.01%) ⬆️
unittests 63.25% <62.50%> (+<0.01%) ⬆️
unittests1 55.57% <ø> (-0.01%) ⬇️
unittests2 34.01% <62.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jackie-Jiang Jackie-Jiang merged commit f29600d into apache:master Jan 14, 2026
37 of 38 checks passed
@Jackie-Jiang Jackie-Jiang deleted the upgrade_parquet branch January 14, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file ingestion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants