NIFI-12403 Improve Jolt UI Parameter Processing#8060
Merged
rfellows merged 2 commits intoapache:mainfrom Nov 22, 2023
Merged
Conversation
Contributor
|
reviewing... |
rfellows
requested changes
Nov 22, 2023
Contributor
rfellows
left a comment
There was a problem hiding this comment.
Just one minor change to keep consistent with how we define string in JavaScript (single quotes). Other than that, this works well.
Comment on lines
411
to
412
| $scope.disconnectedNodeAcknowledged = params.disconnectedNodeAcknowledged === "true"; | ||
| $scope.editable = params.editable === "true"; |
Contributor
There was a problem hiding this comment.
Suggested change
| $scope.disconnectedNodeAcknowledged = params.disconnectedNodeAcknowledged === "true"; | |
| $scope.editable = params.editable === "true"; | |
| $scope.disconnectedNodeAcknowledged = params.disconnectedNodeAcknowledged === 'true'; | |
| $scope.editable = params.editable === 'true'; |
Contributor
Author
There was a problem hiding this comment.
Thanks, I pushed the changes.
rfellows
approved these changes
Nov 22, 2023
Contributor
rfellows
left a comment
There was a problem hiding this comment.
Looks good. Thanks @exceptionfactory !
rfellows
pushed a commit
that referenced
this pull request
Nov 22, 2023
* Improved Jolt UI Parameter Processing * Changed double quotes to single quotes per review This closes #8060
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-12403 Improves the
JoltTransformJSONProcessor custom user interface parameter initialization parsing. The JavaScript controller sets Boolean properties based on initial state parameters, which are passed as strings. Adjusting the processing to use a simple string comparison avoids unnecessary additional parsing.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation