NIFI-15145: Add RecordLookup, KeyValueLookup, and MapCacheClient Services for Couchbase bundle#10467
NIFI-15145: Add RecordLookup, KeyValueLookup, and MapCacheClient Services for Couchbase bundle#10467mark-bathori wants to merge 5 commits intoapache:mainfrom
Conversation
|
any updates on when this PR will be reviewed? |
|
@mark-bathori Do you need any help to resolve the conflicts? I can push a pr to your branch. |
|
@deniswsrosa The PR has been abandoned due to lack of reviewers. I'm reviewing it now and it should be merged soon. |
exceptionfactory
left a comment
There was a problem hiding this comment.
@mark-bathori and @turcsanyip, raising a general question, is it necessary to have all of the added components? Map Cache Client, Key Value Lookup, and Record Lookup are all for different use cases. If you have confirmed usage of all three, that's good, but just raising the question as opposed to simply carrying over what previously existed.
exceptionfactory
left a comment
There was a problem hiding this comment.
@turcsanyip I will hold off on further comments until you have completed your review. On a very cursory scan, I notice a handful of mostly minor concerns related to exception handling, such as lack of detailed messages and exceptions that are never logged in some cases.
Answering the main question about component usage would help guide where to focus review cycles.
Thanks for the work on this!
|
If you all need any help, just let me know, I can also push some fixes.
…On Fri, Jan 16, 2026 at 3:50 PM David Handermann ***@***.***> wrote:
***@***.**** commented on this pull request.
@turcsanyip <https://github.com/turcsanyip> I will hold off on further
comments until you have completed your review. On a very cursory scan, I
notice a handful of mostly minor concerns related to exception handling,
such as lack of detailed messages and exceptions that are never logged in
some cases.
Answering the main question about component usage would help guide where
to focus review cycles.
Thanks for the work on this!
—
Reply to this email directly, view it on GitHub
<#10467 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABUXRQQTSJWABVQAJCBU3T4HD3D7AVCNFSM6AAAAACKKSEVCSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMNZRGIZTKNRSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@exceptionfactory @turcsanyip We could push another PR with the changes requested in this PR if needed. |
turcsanyip
left a comment
There was a problem hiding this comment.
@mark-bathori Please find my review comments below.
Please also rebase the branch to main and update the old 2.7.0 version references.
nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-services/pom.xml
Outdated
Show resolved
Hide resolved
...base-services/src/main/java/org/apache/nifi/services/couchbase/AbstractCouchbaseService.java
Outdated
Show resolved
Hide resolved
...ervices/src/main/java/org/apache/nifi/services/couchbase/CouchbaseKeyValueLookupService.java
Outdated
Show resolved
Hide resolved
...base-services/src/main/java/org/apache/nifi/services/couchbase/AbstractCouchbaseService.java
Outdated
Show resolved
Hide resolved
...hbase-services/src/main/java/org/apache/nifi/services/couchbase/CouchbaseMapCacheClient.java
Outdated
Show resolved
Hide resolved
...hbase-services/src/main/java/org/apache/nifi/services/couchbase/CouchbaseMapCacheClient.java
Outdated
Show resolved
Hide resolved
...hbase-services/src/main/java/org/apache/nifi/services/couchbase/CouchbaseMapCacheClient.java
Outdated
Show resolved
Hide resolved
...hbase-services/src/main/java/org/apache/nifi/services/couchbase/CouchbaseMapCacheClient.java
Outdated
Show resolved
Hide resolved
...hbase-services/src/main/java/org/apache/nifi/services/couchbase/CouchbaseMapCacheClient.java
Outdated
Show resolved
Hide resolved
...ndard-services/src/main/java/org/apache/nifi/services/couchbase/StandardCouchbaseClient.java
Outdated
Show resolved
Hide resolved
|
Thanks @turcsanyip for the review. I'll go through your comments and make the requested changes. |
8218476 to
21e98af
Compare
|
Will the project pom.xml (not the bundle ones) be updated to include couchbase connector into nifi as part of this PR or as a separate change? |
The Couchbase NAR is rather large, given the extensive shaded content of the client library. For this reason, it is not included in the standard |
|
So, users would have to build it manually? Asking because I have to write a tutorial for our site about CB+Nifi and how to use it and, if its not in the assembly then I have this question on what would be the best way for people to install it? Would they have to download the sources, build the nar and install it as a plugin? Ty.
|
All project NAR files are published to Maven Central through the Apache Nexus Repository as part of the standard release process. This allows anyone to download the NAR, without having to build from source, but does require placing the NAR in an extensions directory that NiFi can read. |
1 similar comment
All project NAR files are published to Maven Central through the Apache Nexus Repository as part of the standard release process. This allows anyone to download the NAR, without having to build from source, but does require placing the NAR in an extensions directory that NiFi can read. |
|
Ah, thank you for clarifying, @exceptionfactory |
turcsanyip
left a comment
There was a problem hiding this comment.
@mark-bathori Thanks for the review changes so far. Please find some more review comments below.
Please also rebase the branch to main and update the old 2.8.0 version references.
...hbase-services/src/main/java/org/apache/nifi/services/couchbase/CouchbaseMapCacheClient.java
Outdated
Show resolved
Hide resolved
...hbase-services/src/main/java/org/apache/nifi/services/couchbase/CouchbaseMapCacheClient.java
Outdated
Show resolved
Hide resolved
...hbase-services/src/main/java/org/apache/nifi/services/couchbase/CouchbaseMapCacheClient.java
Outdated
Show resolved
Hide resolved
...ervices/src/main/java/org/apache/nifi/services/couchbase/CouchbaseKeyValueLookupService.java
Show resolved
Hide resolved
...hbase-services/src/main/java/org/apache/nifi/services/couchbase/CouchbaseMapCacheClient.java
Outdated
Show resolved
Hide resolved
...e-services/src/test/java/org/apache/nifi/services/couchbase/CouchbaseMapCacheClientTest.java
Outdated
Show resolved
Hide resolved
...e-services/src/test/java/org/apache/nifi/services/couchbase/CouchbaseMapCacheClientTest.java
Outdated
Show resolved
Hide resolved
…ices for Couchbase bundle
Signed-off-by: Mark Bathori <mbathori@apache.org>
Signed-off-by: Mark Bathori <mbathori@apache.org>
3606263 to
a33c830
Compare
...hbase-services/src/main/java/org/apache/nifi/services/couchbase/CouchbaseMapCacheClient.java
Show resolved
Hide resolved
Signed-off-by: Mark Bathori <mbathori@apache.org>
turcsanyip
left a comment
There was a problem hiding this comment.
Thanks @mark-bathori!
+1 LGTM
@exceptionfactory Do you have any additional comments or can we proceed with the merge?
Summary
NIFI-15145
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation