Skip to content

NIFI-15145: Add RecordLookup, KeyValueLookup, and MapCacheClient Services for Couchbase bundle#10467

Open
mark-bathori wants to merge 5 commits intoapache:mainfrom
mark-bathori:NIFI-15145
Open

NIFI-15145: Add RecordLookup, KeyValueLookup, and MapCacheClient Services for Couchbase bundle#10467
mark-bathori wants to merge 5 commits intoapache:mainfrom
mark-bathori:NIFI-15145

Conversation

@mark-bathori
Copy link
Contributor

Summary

NIFI-15145

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@deniswsrosa
Copy link

any updates on when this PR will be reviewed?

@turcsanyip turcsanyip self-requested a review January 15, 2026 18:16
@deniswsrosa
Copy link

@mark-bathori Do you need any help to resolve the conflicts? I can push a pr to your branch.

@turcsanyip
Copy link
Contributor

@deniswsrosa The PR has been abandoned due to lack of reviewers. I'm reviewing it now and it should be merged soon.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-bathori and @turcsanyip, raising a general question, is it necessary to have all of the added components? Map Cache Client, Key Value Lookup, and Record Lookup are all for different use cases. If you have confirmed usage of all three, that's good, but just raising the question as opposed to simply carrying over what previously existed.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turcsanyip I will hold off on further comments until you have completed your review. On a very cursory scan, I notice a handful of mostly minor concerns related to exception handling, such as lack of detailed messages and exceptions that are never logged in some cases.

Answering the main question about component usage would help guide where to focus review cycles.

Thanks for the work on this!

@deniswsrosa
Copy link

deniswsrosa commented Jan 17, 2026 via email

@deniswsrosa
Copy link

@exceptionfactory @turcsanyip We could push another PR with the changes requested in this PR if needed.

Copy link
Contributor

@turcsanyip turcsanyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-bathori Please find my review comments below.

Please also rebase the branch to main and update the old 2.7.0 version references.

@mark-bathori
Copy link
Contributor Author

Thanks @turcsanyip for the review. I'll go through your comments and make the requested changes.

@mark-bathori mark-bathori force-pushed the NIFI-15145 branch 2 times, most recently from 8218476 to 21e98af Compare February 5, 2026 14:49
@chedim
Copy link

chedim commented Feb 6, 2026

Will the project pom.xml (not the bundle ones) be updated to include couchbase connector into nifi as part of this PR or as a separate change?

@exceptionfactory
Copy link
Contributor

Will the project pom.xml (not the bundle ones) be updated to include couchbase connector into nifi as part of this PR or as a separate change?

The Couchbase NAR is rather large, given the extensive shaded content of the client library. For this reason, it is not included in the standard nifi-assembly binary.

@chedim
Copy link

chedim commented Feb 9, 2026

So, users would have to build it manually? Asking because I have to write a tutorial for our site about CB+Nifi and how to use it and, if its not in the assembly then I have this question on what would be the best way for people to install it? Would they have to download the sources, build the nar and install it as a plugin?

Ty.

Will the project pom.xml (not the bundle ones) be updated to include couchbase connector into nifi as part of this PR or as a separate change?

The Couchbase NAR is rather large, given the extensive shaded content of the client library. For this reason, it is not included in the standard nifi-assembly binary.

@exceptionfactory
Copy link
Contributor

So, users would have to build it manually? Asking because I have to write a tutorial for our site about CB+Nifi and how to use it and, if its not in the assembly then I have this question on what would be the best way for people to install it? Would they have to download the sources, build the nar and install it as a plugin?

Ty.

Will the project pom.xml (not the bundle ones) be updated to include couchbase connector into nifi as part of this PR or as a separate change?

The Couchbase NAR is rather large, given the extensive shaded content of the client library. For this reason, it is not included in the standard nifi-assembly binary.

All project NAR files are published to Maven Central through the Apache Nexus Repository as part of the standard release process. This allows anyone to download the NAR, without having to build from source, but does require placing the NAR in an extensions directory that NiFi can read.

1 similar comment
@exceptionfactory
Copy link
Contributor

So, users would have to build it manually? Asking because I have to write a tutorial for our site about CB+Nifi and how to use it and, if its not in the assembly then I have this question on what would be the best way for people to install it? Would they have to download the sources, build the nar and install it as a plugin?

Ty.

Will the project pom.xml (not the bundle ones) be updated to include couchbase connector into nifi as part of this PR or as a separate change?

The Couchbase NAR is rather large, given the extensive shaded content of the client library. For this reason, it is not included in the standard nifi-assembly binary.

All project NAR files are published to Maven Central through the Apache Nexus Repository as part of the standard release process. This allows anyone to download the NAR, without having to build from source, but does require placing the NAR in an extensions directory that NiFi can read.

@chedim
Copy link

chedim commented Feb 13, 2026

Ah, thank you for clarifying, @exceptionfactory

Copy link
Contributor

@turcsanyip turcsanyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-bathori Thanks for the review changes so far. Please find some more review comments below.

Please also rebase the branch to main and update the old 2.8.0 version references.

Signed-off-by: Mark Bathori <mbathori@apache.org>
Signed-off-by: Mark Bathori <mbathori@apache.org>
Signed-off-by: Mark Bathori <mbathori@apache.org>
Copy link
Contributor

@turcsanyip turcsanyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mark-bathori!

+1 LGTM

@exceptionfactory Do you have any additional comments or can we proceed with the merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments