HTTP Sampler timestamp fix when exception is caught #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the enhancement. Let us hope, that nobody relies on the fact, that failed requests are labelled with the epoch start timestamp. |
|
@kkalinin @FSchumacher In which version of Jmeter this fix is available? |
Contributor
Author
|
@krishna1s, for some reason the change has not been merged to the master branch and so is not available in any of the releases. |
Contributor
Author
I see that the patch has been included into scope of version 5.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when HTTP Sampler fails with exception, the result is timestamped with 1970-01-01.
The proper timestamp is needed.
Motivation and Context
How Has This Been Tested?
Tested manually by comparing timestamps in View Results Tree listener before and after the fix.
With the change, SampleResult contain proper timestamps and 0 duration.
corruptedHTTPSamplerConfig.zip
Screenshots (if appropriate):
Types of changes