Add documentation for Darklaf properties. #613
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that 'darklaf.allowNativeCode' is set to 'true' if 'darklaf.decorations' is 'true'.
FSchumacher
approved these changes
Aug 20, 2020
Contributor
FSchumacher
left a comment
There was a problem hiding this comment.
My test for docs (which mostly gone wrong) is to compile the docs with the corresponding Gradle task.
If the changes are bigger, I do take a look at the resulting pages with a browser.
| static { | ||
| if (System.getProperty("darklaf.decorations") == null) { | ||
| System.setProperty("darklaf.decorations", "false"); | ||
| } else if ("true".equals(System.getProperty("darklaf.allowNativeCode"))) { |
Contributor
There was a problem hiding this comment.
Have you had a look at Boolean.getBoolean(name)? It should do the same as the "true".equals(System.getProperty(...).
Contributor
|
Thanks for the patch |
ham1
pushed a commit
to ham1/jmeter
that referenced
this pull request
Sep 13, 2020
kkalinin
pushed a commit
to kkalinin/jmeter
that referenced
this pull request
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide documentation for some of the darklaf system properties.
This PR also updates darklaf to version 2.4.5 as there have been issues with focus highlighting of table cells.
Version 2.4.5 also provides the system property
darklaf.unifiedMenuBarwhich toggles the unified menubar of darklaf.Motivation and Context
Some people may be interested in using the custom window chrome feature of Darklaf (specifically on Windows).
Because some people dislike unified menubars the corresponding property also is exposed.
How Has This Been Tested?
I'm not entirely sure how to test changes to the documentation. I would appreciate if someone could guide me here on what to do.
Checklist: