Anonymous type can be replaced with lambda + formatting along the way #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
============================================
+ Coverage 55.97% 55.97% +<.01%
- Complexity 9953 9961 +8
============================================
Files 1018 1018
Lines 62744 62741 -3
Branches 7062 7059 -3
============================================
- Hits 35118 35117 -1
+ Misses 25161 25160 -1
+ Partials 2465 2464 -1
Continue to review full report at Codecov.
|
4cde2c8 to
e52661f
Compare
e52661f to
cd88775
Compare
| String m2 = (String) o2.getKey(); | ||
| return m1.compareTo(m2); | ||
| } | ||
| al.sort((o1, o2) -> { |
There was a problem hiding this comment.
I guess this can be further simplified by using Comparator.comparing(Map.Entry::getKey)?
Contributor
There was a problem hiding this comment.
That doesn't work out of the box for me, as the Map isn't typed strong enough.
al.sort(Comparator.comparing(o -> (String) o.getKey()));
could be good, though.
Contributor
Author
There was a problem hiding this comment.
That doesn't seem to compile, I think they need to be cast to Strings first.
asfgit
pushed a commit
that referenced
this pull request
Oct 3, 2019
Incorporate note from pascalschumacher. Relates to #520 on github
Collaborator
|
This causes the following exception when right-clicking on the "test plan": |
Collaborator
|
That means we don't have a UI test that would build a basic test plan via the context menu :-/ |
Contributor
What is strange is not it didn't compile in my Eclipse, I faced the issue this morning using current master code in my work, so I don't understand how it does using gradle, or is there a missing clean (which I don't think is the case)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #514