Fix: Typos #480
Closed
Fix: Typos #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljacqu
reviewed
Aug 22, 2019
| // triggerEndOfLoop is called when error occurs to end Main Loop | ||
| // in this case normal workflow doesn't happen, so we need | ||
| // to notify the childs of TransactionController and | ||
| // to notify the child of TransactionController and |
Contributor
Author
There was a problem hiding this comment.
yes, you're right :)
FSchumacher
reviewed
Aug 24, 2019
|
|
||
| /** | ||
| * Hard Stop JMeterThread thrd and interrupt JVM Thread if interrupt is true | ||
| * Hard Stop JMeterThread third and interrupt JVM Thread if interrupt is true |
Contributor
There was a problem hiding this comment.
This is probably thread and not third. We could probably get rid of thr*d here at all.
asfgit
pushed a commit
that referenced
this pull request
Aug 25, 2019
Contributor
|
Thanks for the pull request. It is always nice to know that someone looks at the code and cares enough to send in changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: