Use SHA-512 checksums instead of MD5 to verify jar downloads #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 Thanks |
asfgit
pushed a commit
that referenced
this pull request
Oct 12, 2018
Followup to r1843694 Use SHA-512 checksums instead of MD5 to verify jar downloads Relates #405 on github Bugzilla Id: 62821 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1843699 13f79535-47bb-0310-9956-ffa450edef68
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Closes apache#405 on github Bugzilla Id: 62821 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1843694 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: ffaee6c
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Followup to r1843694 Use SHA-512 checksums instead of MD5 to verify jar downloads Relates apache#405 on github Bugzilla Id: 62821 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1843699 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 3083109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the checksums for the downloaded jars from MD5 to SHA-512.
Motivation and Context
MD5 is considered broken, so we should verify downloaded artefacts for our build process with a non broken checksum. SHA-512 is considered safe -- at the moment.
How Has This Been Tested?
ant download_jarsand other download targets have been run without problems.Screenshots (if appropriate):
Types of changes
Checklist:
No documentation found for the old md5 checksums construct.