Adds a time boxed sampling for backend listeners #237
Conversation
git-svn-id: https://svn.apache.org/repos/asf/jmeter/tags/v3_1_RC4@1770033 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jmeter/tags/v3_1@1770529 13f79535-47bb-0310-9956-ffa450edef68
FSchumacher
left a comment
There was a problem hiding this comment.
Thanks for the contribution.
Overall it looks good. Maybe you could also describe the use case for this feature compared to the fixed-size one.
|
|
||
| /** | ||
| * Metrics are sent into boxes which can be {@link #FIXED a fixed-size sliding window} or {@link #TIMED time boxed}. | ||
| * @author Logan Mzz |
There was a problem hiding this comment.
We don't use the author doc tag.
| stat.clear(); | ||
| } | ||
| break; | ||
| default: throw new UnsupportedOperationException(windowMode.name()); |
There was a problem hiding this comment.
Seems like a formatting error
| // http://commons.apache.org/proper/commons-math/userguide/stat.html | ||
| break; | ||
| case TIMED: | ||
| for (DescriptiveStatistics stat : windowedStats) { |
There was a problem hiding this comment.
JMeter now uses java 8, so we could use the newer syntax :)
|
|
||
| int slidingWindowSize = JMeterUtils.getPropDefault("backend_metrics_window", 100); | ||
| // Limit to sliding window of SLIDING_WINDOW_SIZE values | ||
| for (DescriptiveStatistics stat : stats) { |
| #--------------------------------------------------------------------------- | ||
| # | ||
| # Backend metrics window mode (fixed=fixed-size window, timed=time boxed) | ||
| #backend_metrics_window_mode=fixed |
There was a problem hiding this comment.
Documentation is missing for this new feature. It should be mentioned in the properties section and the users manual.
|
Hello @max3163, |
|
When you use the fixed metric window mode, all samples metrics are saved in a sliding array with a fix size, you send each second to your backend a trend of this values |
|
Hello Team, |
|
This sounds good if it's what I think it is. Definitely would appreciate a clear description of what it precisely does, though. |
|
@max3163 , are you using GraphiteBackendListener or something else (I don't fully understand your comment on "I'm thinking to send a PR to share it too". |
|
@pmouawad |
|
Hello, Thank you |
|
Hi, I just sent you a new PR ( #246 ) for the Influxdb backend. |
These tests only work with the apache#237 PR merged and timed mode box
No description provided.