Bug 59885 Optimize css parsing for embedded resources download #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the css parser is essential to test real world applications with embedded resources download. But it's heavy on cpu and memory allocations. this commit add a lru cache which saves the url extracted from the css file. the key of the cache is the md5 of the css file. the cache is not enabled by default (but should probably be) To activate it, a value > 0 must be set for the key 'css.parser.cache.size' in the jmeter config file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the css parser is essential to test real world applications with
embedded resources download.
But it's heavy on cpu and memory allocations.
this commit add a lru cache which saves the url extracted from the css
file.
the key of the cache is the md5 of the css file.
the cache is not enabled by default (but should probably be)
To activate it, a value > 0 must be set for the key
'css.parser.cache.size' in the jmeter config file