Parquet: Support reading INT96 column in row group filter #8988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
17ed58a to
bbbcccb
Compare
nastra
reviewed
Nov 6, 2023
parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java
Outdated
Show resolved
Hide resolved
bbbcccb to
4f0c48e
Compare
4f0c48e to
275aa34
Compare
nastra
reviewed
Nov 7, 2023
parquet/src/main/java/org/apache/iceberg/parquet/ParquetConversions.java
Show resolved
Hide resolved
nastra
approved these changes
Nov 7, 2023
Contributor
nastra
left a comment
There was a problem hiding this comment.
LGTM with one suggestion and once CI passes
Contributor
|
@manuzhang does that also fix #8949 or is that a different root cause? |
Member
Author
Member
Author
|
Any more comments? |
Contributor
|
I think it would be good to also get the opinion of @RussellSpitzer or @aokolnychyi on this one |
Member
Author
|
@RussellSpitzer @aokolnychyi could you please take a look? |
Member
Author
|
gentle ping @nastra @RussellSpitzer @aokolnychyi |
d5ac567 to
b05dfaa
Compare
Member
Author
|
I submitted #9408 to fix failed flaky test. |
Member
Author
|
@nastra can we move forward with this PR? |
nastra
reviewed
Jan 5, 2024
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java
Show resolved
Hide resolved
dce3a37 to
12c2e6e
Compare
2474e37 to
cc8b63b
Compare
cc8b63b to
ddd3cd1
Compare
nastra
approved these changes
Jan 8, 2024
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
adnanhemani
pushed a commit
to adnanhemani/iceberg
that referenced
this pull request
Jan 30, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #8990