Core: Scan only live entries for partitions table #8969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
dramaticlly
commented
Nov 1, 2023
spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java
Show resolved
Hide resolved
ajantha-bhat
approved these changes
Nov 1, 2023
flyrain
approved these changes
Nov 1, 2023
Contributor
flyrain
left a comment
There was a problem hiding this comment.
+1 Thanks for the fix, @dramaticlly! Curious if we need the test for spark3.3 and 3.2.
spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java
Show resolved
Hide resolved
dramaticlly
commented
Nov 1, 2023
Contributor
Author
dramaticlly
left a comment
There was a problem hiding this comment.
Added corresponding unit test for spark 3.2 and 3.3.
spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java
Show resolved
Hide resolved
aokolnychyi
approved these changes
Nov 1, 2023
Contributor
|
Thanks, @dramaticlly! Thanks for reviewing, @ajantha-bhat @Fokko @flyrain! |
zhangbutao
added a commit
to zhangbutao/hive
that referenced
this pull request
Nov 2, 2023
zhangbutao
added a commit
to zhangbutao/hive
that referenced
this pull request
Nov 3, 2023
zhangbutao
added a commit
to zhangbutao/hive
that referenced
this pull request
Nov 8, 2023
zhangbutao
added a commit
to zhangbutao/hive
that referenced
this pull request
Nov 9, 2023
|
Hello, thanks for the fix! Will it be backported to 1.4.x? |
Fokko
pushed a commit
to Fokko/iceberg
that referenced
this pull request
Dec 3, 2023
Co-authored-by: Steve Zhang <hongyue_zhang@apple.com>
Contributor
nastra
pushed a commit
that referenced
this pull request
Dec 19, 2023
parthchandra
pushed a commit
to parthchandra/iceberg
that referenced
this pull request
Oct 22, 2025
…e#1297) backport apache#8969 Co-authored-by: Hongyue/Steve Zhang <steveiszhy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #8951
This help fix the bug introduced in #7581 where partition table scan entries instead of files to have partition level stats aggregagted over files. In order to have correct stats, only live entries need to be scanned instead of all entries