Flink:backport PR to 1.15 #7360: Implement data statistics coordinator to aggregate data statistics from operator subtasks #8749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dinator to aggregate data statistics from operator subtasks
yegangy0718
commented
Oct 10, 2023
| } | ||
|
|
||
| @Override | ||
| public void subtaskFailed(int subtask, @Nullable Throwable reason) { |
Contributor
Author
There was a problem hiding this comment.
the interface gets changed to public void executionAttemptFailed(int subtask, int attemptNumber, @Nullable Throwable reason) in Flink 1.16
| } | ||
|
|
||
| @Override | ||
| public void subtaskReady(int subtask, SubtaskGateway gateway) { |
Contributor
Author
There was a problem hiding this comment.
the interface gets changed to public void executionAttemptReady(int subtask, int attemptNumber, SubtaskGateway gateway) in Flink 1.16
| } | ||
|
|
||
| @Override | ||
| public void subtaskReset(int subtask, long checkpointId) { |
Contributor
Author
There was a problem hiding this comment.
the interface is unchanged. But the subtaskGateway in Flink 1.16 is Map<Integer, SubtaskGateway>[] gateways who map key is attempt num, while in Flink 1.15 we don't need to track the attemp num. Thus this is nothing we need to do in subtaskRest.
stevenzwu
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it isn't a clean back port because OperatorCoordinator gets changed in Flink-runtime 1.16