AWS: support config storage class for S3FileIO #8154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@nastra please help review |
nastra
reviewed
Jul 26, 2023
Contributor
nastra
left a comment
There was a problem hiding this comment.
The changes make sense, but I think we need to do the same for initializeMultiPartUpload(). Can you please add some tests to TestS3FileIOProperties?
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jul 26, 2023
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIOProperties.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jul 26, 2023
Contributor
Author
|
@nastra hi, we have refined the unit tests of TestS3FileIOProperties, please help review |
nastra
reviewed
Aug 15, 2023
nastra
approved these changes
Aug 15, 2023
nastra
approved these changes
Aug 15, 2023
Contributor
Author
|
hi @nastra I added a spotlessApply |
nastra
approved these changes
Aug 18, 2023
Contributor
|
Thanks @gegef2009 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS: support config storage class for S3FileIO , to solve issue: #8153